Merged
Conversation
Member
Author
|
@simeonschaub gave the thumbs up to this, conceptually. Still needs review |
nickrobinson251
approved these changes
Jan 5, 2020
Contributor
nickrobinson251
left a comment
nickrobinson251
left a comment
There was a problem hiding this comment.
Code changes seem correct as far as i can see. (Given @oxinabox and @simeonschaub agree this is the thing we want to do for now). 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actionizes #40 , until we can do #54 and do Wirtinger right.
If we do this it unblocks #76 since we delete the tests that turned out to be broken anyway.
Will need follow up in ChainRules to delete the rules that currently use that.
But that can come later when we are closer to releasing 0.5
(Since there are a bunch of outstanding PRs still)